Skip to content

fix: add missing auth.oidc validation in helm chart #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonwiggins merged 3 commits into from
May 7, 2026
Merged

fix: add missing auth.oidc validation in helm chart #528

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
adcb18b
fix: add missing auth.oidc validation
5rk7n May 1, 2026
03b7981
fix: update _helpers.tpl for oidc with issuerUrl
5rk7n May 4, 2026
52dcb42
fix: typo clientId
5rk7n May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions helm/optio/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,9 +47,9 @@ Called from secrets.yaml to fail early on misconfiguration.
{{- if not .Values.publicUrl -}}
{{- fail "publicUrl is required when auth is enabled. Set to the externally-reachable URL (e.g. https://optio.example.com)." -}}
{{- else -}}
{{- $hasProvider := or .Values.auth.github.clientId (or .Values.auth.google.clientId .Values.auth.gitlab.clientId) -}}
{{- $hasProvider := or .Values.auth.github.clientId (or .Values.auth.google.clientId (or .Values.auth.gitlab.clientId .Values.auth.oidc.issuerUrl)) -}}
{{- if not $hasProvider -}}
{{- fail "At least one OAuth provider must be configured when auth is enabled. Set auth.github.clientId, auth.google.clientId, or auth.gitlab.clientId (with corresponding clientSecret)." -}}
{{- fail "At least one OAuth provider must be configured when auth is enabled. Set auth.github.clientId, auth.google.clientId, auth.gitlab.clientId, or auth.oidc.issuerUrl (with corresponding clinetId, clientSecret as needed)." -}}

@jonwiggins jonwiggins May 5, 2026

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny typo: clinetId → clientId in this user-facing error message.

@5rk7n 5rk7n May 5, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry for that. Fix typo in the messages now.

{{- end -}}
{{- end -}}
{{- end -}}
Expand Down
Loading