test: add boundary tests for text(max_nb_chars) - #2439
Open
saimoon504 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2389
Brief summary: adds three tests to tests/providers/test_lorem.py
pinning down the boundary behavior of text(max_nb_chars).
What was wrong
The existing lorem tests exercise text() per locale but do not test
its boundary behavior. While testing Faker for a university course we
noticed this gap when investigating #2389.
How this fixes it
Adds a TestTextBounds class with three tests:
checked around the internal mode switches at 25 and 100 characters
(enforced in the code but previously untested)
output comes from the given list
All three pass locally: 3 passed in 0.67s on Python 3.10.12.