Fix IRC SASL PLAIN using wrong credentials (NickServNick/Password) - #3
Closed
johnnyxmas wants to merge 1 commit into
Closed
Fix IRC SASL PLAIN using wrong credentials (NickServNick/Password)#3johnnyxmas wants to merge 1 commit into
johnnyxmas wants to merge 1 commit into
Conversation
UseSASL wired girc.SASLPlain to NickServNick/NickServPassword, but those fields hold the NickServ *target* to message (defaults to "NickServ", e.g. QuakeNet's "Q@CServe.quakenet.org") for the non-SASL post-connect IDENTIFY path, not an account name. Any standard NickServ setup using SASL therefore authenticated as an account literally named "NickServ", failing with "Account does not exist" on ircds that don't have one (e.g. Ergo). Adds dedicated SASLLogin/SASLPassword config fields and wires SASL to those instead, falling back to Nick when SASLLogin is unset. Verified live against an Ergo ircd: SASL PLAIN now completes with 900/903 (logged in / authentication successful) using SASLLogin.
Owner
Author
|
Wrong target — meant to open this against upstream 42wim/matterbridge instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UseSASLwiredgirc.SASLPlaintoNickServNick/NickServPassword, but those fields hold the NickServ target to message (default"NickServ", or e.g. QuakeNet'sQ@CServe.quakenet.org) for the non-SASL post-connectIDENTIFYpath — not an account name."NickServ", failing withAccount does not existon ircds that don't have one (e.g. Ergo).SASLLogin/SASLPasswordconfig fields and wires SASL to those instead, falling back toNickwhenSASLLoginis unset (matches prior implicit behavior for the common case where nick == account).Test plan
Birc.Connect()code path (not just a compile check):AUTHENTICATE PLAIN→900 ... logged in as <account>→903 Authentication successful.go build/go vet/gofmtclean onbridge/configandbridge/irc.bridge/slackcurrently fails to build on this fork independent of this change (slackevents.MessageEventmissing fields the code expects), pre-existing onmaster.