CI dry run: gtk4 branch#1
Draft
johncarmack1984 wants to merge 23 commits into
Draft
Conversation
closes tauri-apps#270 kicking off work on gtk4 migration help is appreciated
Builds on the feat/gtk4 backend: brings in the extension work from rmakestrash's fork and adapts everything to dev's current API, so the public surface stays what dev ships today and call sites compile unchanged. - gtk4 0.11 and png 0.18, MSRV 1.92 to match gtk4's floor - the gtk dependency is optional behind a `gtk` feature (part of default) with dev's BSD-wide target cfg; `libxdo` stays as a no-op feature name for compatibility - shared modules follow dev's current API (the KeyAccelerator line); the only changes there are the feature and target cfg gates - backend methods keep their gtk3 names and shapes; only widget types move with the toolkit (Menu to PopoverMenu, MenuBar to PopoverMenuBar, Container bounds to Widget) - predefined item accelerators are wired on gtk, matching macOS - KeyAccelerator::to_gtk covers the Key-based accelerator path Co-authored-by: amrbashir <github@amrbashir.me> Co-authored-by: rmakestrash-jpg <rmakestrash-jpg@users.noreply.github.com>
GTK4's PopoverMenu does not render icons set on a gio::MenuItem, which is why menu icons were blank on the gtk4 backend. Mark icon items with a `custom` attribute and bind an icon+label widget (a flat button carrying the item's action) via PopoverMenu/PopoverMenuBar add_child; the binding reaches nested submenu slots too. Context menus rebuild on show so label, icon, and checked-state changes are reflected instead of showing a stale first build. Verified headless (xvfb) with a menu whose icon and label are mutated live: the icon renders and updates, addressing the icon issue tracked in tauri-apps#270.
The runners need libgtk-4-dev next to the existing gtk3 packages, which stay for the tao and wry dev-dependencies. The test job's pinned toolchain moves to 1.92 to match the crate's MSRV, set via the action's toolchain input because dtolnay/rust-toolchain has no 1.92 tag.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork-internal dry run of the full workflow matrix for tauri-apps#369. Not for merge.