Skip to content
Open
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cva/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"npm-run-all": "4.1.5",
"react": "18.2.0",
"react-dom": "18.2.0",
"tinybench": "^2.7.0",
"ts-node": "10.8.1",
"typescript": "5.1.3"
},
Expand Down
162 changes: 162 additions & 0 deletions packages/cva/src/benchmark.ts

@fveracoechea fveracoechea Feb 9, 2025

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to mention, this file is just for benchmarking purposes, basically making sure these changes are actually faster, could be removed before merging.

Original file line number Diff line number Diff line change
@@ -0,0 +1,162 @@
import { Bench } from "tinybench";

import { defineConfig as originalDefineConfig } from "./old-index";
import { defineConfig as enhancedDefineConfig } from "./index";

function logResultsTable(bench: Bench) {
const table: any[] = [];

for (const task of bench.tasks) {
if (!task.result) continue;
table.push({
name: task.name,
"ops/sec": task.result.error ? 0 : task.result.hz,
"average (ms)": task.result.error ? "NaN" : task.result.mean.toFixed(3),
samples: task.result.error ? "NaN" : task.result.samples.length,
});
}

const results = table
.map((x) => ({
...x,
"ops/sec": parseFloat(parseInt(x["ops/sec"].toString(), 10).toString()),
}))
.sort(
(a: Record<string, number>, b: Record<string, number>) =>
b["ops/sec"] - a["ops/sec"],
);

const maxOps = Math.max(...results.map((x) => x["ops/sec"]));

console.table(
results.map((x, i) => ({
...x,
[`relative to ${results[0]["name"]}`]:
i === 0
? ""
: `${(maxOps / parseInt(x["ops/sec"])).toFixed(2)} x slower`,
})),
);
}

const originalCVA = originalDefineConfig().cva;
const enhancedCVA = enhancedDefineConfig().cva;

const buttonWithoutBaseWithDefaultsWithClassNameString = {
base: "button font-semibold border rounded",
variants: {
intent: {
unset: null,
primary:
"button--primary bg-blue-500 text-white border-transparent hover:bg-blue-600",
secondary:
"button--secondary bg-white text-gray-800 border-gray-400 hover:bg-gray-100",
warning:
"button--warning bg-yellow-500 border-transparent hover:bg-yellow-600",
danger: [
"button--danger",
[
1 && "bg-red-500",
{ baz: false, bat: null },
["text-white", ["border-transparent"]],
],
"hover:bg-red-600",
],
},
disabled: {
unset: null,
true: "button--disabled opacity-050 cursor-not-allowed",
false: "button--enabled cursor-pointer",
},
size: {
unset: null,
small: "button--small text-sm py-1 px-2",
medium: "button--medium text-base py-2 px-4",
large: "button--large text-lg py-2.5 px-4",
},
m: {
unset: null,
0: "m-0",
1: "m-1",
},
},
compoundVariants: [
{
intent: "primary",
size: "medium",
className: "button--primary-medium uppercase",
},
{
intent: "warning",
disabled: false,
className: "button--warning-enabled text-gray-800",
},
{
intent: "warning",
disabled: true,
className: [
"button--warning-disabled",
[1 && "text-black", { baz: false, bat: null }],
],
},
{
intent: ["warning", "danger"],
className: "button--warning-danger !border-red-500",
},
{
intent: ["warning", "danger"],
size: "medium",
className: "button--warning-danger-medium",
},
],
defaultVariants: {
m: 0,
disabled: false,
intent: "primary",
size: "medium",
},
} as any;

async function run() {
const benchmark = new Bench({ time: 5000 });

benchmark.add("cva/main", () => {
const buttonVariants = originalCVA(
buttonWithoutBaseWithDefaultsWithClassNameString,
);
buttonVariants({});
buttonVariants({ intent: "primary", disabled: true } as any);
buttonVariants({ intent: "primary", size: "medium" } as any);
buttonVariants({
intent: "warning",
size: "medium",
disabled: true,
} as any);
buttonVariants({ size: "small" } as any);
buttonVariants({ size: "large", intent: "unset" } as any);
});

benchmark.add("feat/performance-enhancement", () => {
const buttonVariants = enhancedCVA(
buttonWithoutBaseWithDefaultsWithClassNameString,
);
buttonVariants({});
buttonVariants({ intent: "primary", disabled: true } as any);
buttonVariants({ intent: "primary", size: "medium" } as any);
buttonVariants({
intent: "warning",
size: "medium",
disabled: true,
} as any);
buttonVariants({ size: "small" } as any);
buttonVariants({ size: "large", intent: "unset" } as any);
});

await benchmark.warmup();
await benchmark.run();
logResultsTable(benchmark);

process.exit();
}

run();
Loading