FLUID-6324: use @waharnum's fork of docpad-plugin-handlebars#1
Merged
Conversation
Owner
|
@waharnum thanks for providing this stop gap while we wait for them to merge your PR. |
Author
|
As noted in our convo, this doesn't work in current state because of the compile step that happens (typically) as part of the plug-in publishing to NPM. Working around this is probably a matter of publishing a branch with the compile step completed (publishing our own version to NPM seems like overkill). |
Owner
|
If we end up publishing to NPM we should publish it as an org scoped package ( https://docs.npmjs.com/creating-and-publishing-an-org-scoped-package ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've fixed the Handlebars plugin for the 6.82.x line of Docpad.
I will open a pull request to the plug-in to discuss my fix and potentially get it merged upstream, but for now this allows the docs site to be generated with the 6.82.x line of Docpad.
My PR at docpad/docpad-plugin-handlebars#13 - we can update our use of the plugin should that get merged.