refactor: Use IAppConfig in admin settings - #95
Closed
CarlSchwan wants to merge 1 commit into
Closed
Conversation
Simplify the code a bit and remove some deprecated API usages Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
carl/appconfig
branch
from
August 4, 2026 11:07
c787865 to
098462e
Compare
jo23sh
marked this pull request as draft
August 10, 2026 17:15
Owner
|
@CarlSchwan Is this PR still relevant, given that I've basically completely rewritten the config to declarative settings in 42e48f8 ? |
Contributor
Author
|
I don't think so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the code a bit and remove some deprecated API usages