Fix file upload when using mDNS#57
Open
Jfhow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using mDNS to connect FluidTouch to FluidNC, file uploads would fail. The call to FluidNCClient::getMachineIP from the upload procedure was not using mDNS to resolve the IP address and was just using the url from the connection definition.
The connection procedure, FluidNCClient::connect, used during initial connection of FluidTouch to FluidNC, does have an mDNS capability.
I made changes to save the IP address resolved during initial connect and then reuse this IP during file uploads.
I added a field to Machine Config to store the IP address that is resolved during initial connection. I added a line to FluidNCClient::connect. to save the resolved IP address to this field.
I revised FluidNCClient::getMachineIP to use the IP address saved in Machine Config instead of the url from the connection box.
I tested this on a Basic display and a version 1.4 Advanced display.
I tested by using a hard coded IP address in the connection configuration, and by using fluidnc.local in the configuration.