-
Notifications
You must be signed in to change notification settings - Fork 348
fix(nginx plugin): place mime.types next to nginx.conf so include resolves #2918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mikeland73
wants to merge
2
commits into
main
Choose a base branch
from
claude/focused-goldberg-srxxak
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,98 @@ | ||
| types { | ||
| text/html html htm shtml; | ||
| text/css css; | ||
| text/xml xml; | ||
| image/gif gif; | ||
| image/jpeg jpeg jpg; | ||
| application/javascript js; | ||
| application/atom+xml atom; | ||
| application/rss+xml rss; | ||
|
|
||
| text/mathml mml; | ||
| text/plain txt; | ||
| text/vnd.sun.j2me.app-descriptor jad; | ||
| text/vnd.wap.wml wml; | ||
| text/x-component htc; | ||
|
|
||
| image/avif avif; | ||
| image/png png; | ||
| image/svg+xml svg svgz; | ||
| image/tiff tif tiff; | ||
| image/vnd.wap.wbmp wbmp; | ||
| image/webp webp; | ||
| image/x-icon ico; | ||
| image/x-jng jng; | ||
| image/x-ms-bmp bmp; | ||
|
|
||
| font/woff woff; | ||
| font/woff2 woff2; | ||
|
|
||
| application/java-archive jar war ear; | ||
| application/json json; | ||
| application/mac-binhex40 hqx; | ||
| application/msword doc; | ||
| application/pdf pdf; | ||
| application/postscript ps eps ai; | ||
| application/rtf rtf; | ||
| application/vnd.apple.mpegurl m3u8; | ||
| application/vnd.google-earth.kml+xml kml; | ||
| application/vnd.google-earth.kmz kmz; | ||
| application/vnd.ms-excel xls; | ||
| application/vnd.ms-fontobject eot; | ||
| application/vnd.ms-powerpoint ppt; | ||
| application/vnd.oasis.opendocument.graphics odg; | ||
| application/vnd.oasis.opendocument.presentation odp; | ||
| application/vnd.oasis.opendocument.spreadsheet ods; | ||
| application/vnd.oasis.opendocument.text odt; | ||
| application/vnd.openxmlformats-officedocument.presentationml.presentation | ||
| pptx; | ||
| application/vnd.openxmlformats-officedocument.spreadsheetml.sheet | ||
| xlsx; | ||
| application/vnd.openxmlformats-officedocument.wordprocessingml.document | ||
| docx; | ||
| application/vnd.wap.wmlc wmlc; | ||
| application/wasm wasm; | ||
| application/x-7z-compressed 7z; | ||
| application/x-cocoa cco; | ||
| application/x-java-archive-diff jardiff; | ||
| application/x-java-jnlp-file jnlp; | ||
| application/x-makeself run; | ||
| application/x-perl pl pm; | ||
| application/x-pilot prc pdb; | ||
| application/x-rar-compressed rar; | ||
| application/x-redhat-package-manager rpm; | ||
| application/x-sea sea; | ||
| application/x-shockwave-flash swf; | ||
| application/x-stuffit sit; | ||
| application/x-tcl tcl tk; | ||
| application/x-x509-ca-cert der pem crt; | ||
| application/x-xpinstall xpi; | ||
| application/xhtml+xml xhtml; | ||
| application/xspf+xml xspf; | ||
| application/zip zip; | ||
|
|
||
| application/octet-stream bin exe dll; | ||
| application/octet-stream deb; | ||
| application/octet-stream dmg; | ||
| application/octet-stream iso img; | ||
| application/octet-stream msi msp msm; | ||
|
|
||
| audio/midi mid midi kar; | ||
| audio/mpeg mp3; | ||
| audio/ogg ogg; | ||
| audio/x-m4a m4a; | ||
| audio/x-realaudio ra; | ||
|
|
||
| video/3gpp 3gpp 3gp; | ||
| video/mp2t ts; | ||
| video/mp4 mp4; | ||
| video/mpeg mpeg mpg; | ||
| video/quicktime mov; | ||
| video/webm webm; | ||
| video/x-flv flv; | ||
| video/x-m4v m4v; | ||
| video/x-mng mng; | ||
| video/x-ms-asf asx asf; | ||
| video/x-ms-wmv wmv; | ||
| video/x-msvideo avi; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch — confirmed against
internal/plugin/plugin.go:241-243:shouldCreateFile()returnsfalsefor anydevbox.d/path once the plugin is installed (PluginVersion != ""), and the version bump doesn't reset that (it's a non-empty check, not a version comparison). So placingmime.typesin{{ .DevboxDir }}would leave existing installs broken.I've switched to your option (b):
mime.typesstays in the virtenv ({{ .Virtenv }}, under.devbox, always regenerated), andprocess-compose.yaml— also regenerated under.devbox— now copies it into$NGINX_CONFDIRnext tonginx.confat service start when missing:This remediates both fresh and already-installed projects. Pushed in b39af3a.
Generated by Claude Code