Skip to content

Update SlackUploadFileStep help-channel to use channel ID instead of … - #998

Open
orcunbalcilar wants to merge 1 commit into
jenkinsci:masterfrom
orcunbalcilar:master
Open

Update SlackUploadFileStep help-channel to use channel ID instead of …#998
orcunbalcilar wants to merge 1 commit into
jenkinsci:masterfrom
orcunbalcilar:master

Conversation

@orcunbalcilar

@orcunbalcilar orcunbalcilar commented Aug 13, 2024

Copy link
Copy Markdown

…channel name to fix misleading docs issue

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@orcunbalcilar
orcunbalcilar requested a review from a team as a code owner August 13, 2024 19:04

@timja timja left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't correct, whilst channel ids will be more efficient channel names are supported just fine:
https://github.com/jenkinsci/slack-plugin/blob/master/src/main/java/jenkins/plugins/slack/cache/SlackChannelIdCache.java#L69

@orcunbalcilar

Copy link
Copy Markdown
Author

Ok, I thought it would support both. But tried many times. Only id worked. Neither channel-name nor #channel-name was able to work. I had a look at the source code. Yes some support codes were there. But no result. Maybe this is a bug. Let me check it out again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants