Skip to content

Backporting for LTS 2.516.1 (part 1) - #10808

Merged
MarkEWaite merged 12 commits into
jenkinsci:stable-2.516from
MarkEWaite:stable-2.516-backport-1
Jul 7, 2025
Merged

Backporting for LTS 2.516.1 (part 1)#10808
MarkEWaite merged 12 commits into
jenkinsci:stable-2.516from
MarkEWaite:stable-2.516-backport-1

Conversation

@MarkEWaite

@MarkEWaite MarkEWaite commented Jul 5, 2025

Copy link
Copy Markdown
Contributor

Backporting for LTS 2.516.1 (part 1)

See

JENKINS-75818           Minor                   2.517
        In case custom plugins add items to the breadcrumb the initial rendering is not collapsing the path
        https://issues.jenkins.io/browse/JENKINS-75818

JENKINS-75834           Major                   2.518
        Dropdown can produce multiples dropdowns visible
        https://issues.jenkins.io/browse/JENKINS-75834

JENKINS-75853           Minor                   2.518
        Secondary actions in header look focused
        https://issues.jenkins.io/browse/JENKINS-75853

JENKINS-75832           Major                   2.518
        actions in the hamburger menu with badges do not render correctly
        https://issues.jenkins.io/browse/JENKINS-75832

JENKINS-75849           Major                   2.518
        script console can be used with sidepanel
        https://issues.jenkins.io/browse/JENKINS-75849

Testing done

Confirmed each of the individual commits in the pull request matches the original commit on the master branch.

Ran a quick-build and confirmed that the active look of hamburger button was resolved.

Proposed changelog entries

N/A

Proposed changelog category

/label into-lts

Proposed upgrade guidelines

N/A

Submitter checklist

  • The Jira issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

scherler and others added 5 commits July 5, 2025 15:32
Signed-off-by: Thorsten Scherler <scherler@gmail.com>

(cherry picked from commit 802a219)

From pull request

* jenkinsci#10772
Co-authored-by: James Nord <jtnord@users.noreply.github.com>

(cherry picked from commit c9319a7)

From pull request

* jenkinsci#10772
Signed-off-by: Thorsten Scherler <scherler@gmail.com>

(cherry picked from commit 660a031)

From pull request:

* jenkinsci#10786
Signed-off-by: Thorsten Scherler <scherler@gmail.com>

(cherry picked from commit 3a98005)

From pull request:

* jenkinsci#10786
(cherry picked from commit 9eee8a9)

From pull request

* jenkinsci#10804
@MarkEWaite MarkEWaite added the into-lts This PR is filed against an LTS branch label Jul 5, 2025
alecharp and others added 7 commits July 5, 2025 16:38
(cherry picked from commit fdd8f1f)

From pull request:

* jenkinsci#10800
(cherry picked from commit 3f45b6d)

From pull request:

* jenkinsci#10800
This adds support for Badges from RootActions in the Hamburger Menu (but
more generically within dropdowns).

(cherry picked from commit 76eeaf1)

From pull request:

* jenkinsci#10791
(cherry picked from commit 0af57ba)

Merge conflict resolved from commit 06d9b39

From pull request:

* jenkinsci#10791
Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com>

(cherry picked from commit 88d6a48)

From pull request:

* jenkinsci#10791
@MarkEWaite

Copy link
Copy Markdown
Contributor Author

The failing test inQueueTaskLookupByAPI is reported as flaky by launchable

@NotMyFault
NotMyFault requested a review from a team July 6, 2025 07:02
@MarkEWaite
MarkEWaite merged commit f0c5d46 into jenkinsci:stable-2.516 Jul 7, 2025
@MarkEWaite
MarkEWaite deleted the stable-2.516-backport-1 branch July 7, 2025 00:09
animation: "dropdown",
duration: 250,
onShow: (instance) => {
// Make sure only one instance is visible at all times

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MarkEWaite added a commit to MarkEWaite/jenkins that referenced this pull request Jul 9, 2025
Change causes test failures in the acceptance test harness.  Pull request
that shows the test failures is:

* jenkinsci#10786

Pull request that introduced the failure on this branch is:

* jenkinsci#10808

This reverts commit 83e090c.
MarkEWaite added a commit to MarkEWaite/jenkins that referenced this pull request Jul 9, 2025
…s visible"

Change causes test failures in the acceptance test harness.  Pull request
that shows the test failures is:

* jenkinsci#10786

Pull request that introduced the failure on this branch is:

* jenkinsci#10808

This reverts commit 0d6354c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

into-lts This PR is filed against an LTS branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants