Skip to content

Make xbanish C99 compliant #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iacore wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make xbanish C99 compliant #70

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
57f6829
Make xbanish C99 compliant
iacore Apr 12, 2022
3816194
Update xbanish.c
iacore Apr 18, 2022
0e52daa
Merge branch 'master' into master
iacore Apr 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

CC ?= cc
CFLAGS ?= -O2
CFLAGS += -Wall -Wunused -Wmissing-prototypes -Wstrict-prototypes
CFLAGS += -std=c99 -Wall -Wunused -Wmissing-prototypes -Wstrict-prototypes

PREFIX ?= /usr/local
BINDIR ?= $(PREFIX)/bin
Expand Down
6 changes: 4 additions & 2 deletions xbanish.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,16 @@
* OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
*/

#define _POSIX_C_SOURCE 2

@N-R-K N-R-K Apr 12, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it's better to define feature test macros in the Makefile under CPPFLAGS variable. But since it's a single file source, probably doesn't matter much.


#include <err.h>
#include <signal.h>
#include <stdlib.h>
#include <stdio.h>
#include <string.h>
#include <unistd.h>
#include <stdbool.h>
#include <strings.h>

#include <X11/X.h>
#include <X11/Xlib.h>
#include <X11/extensions/sync.h>
#include <X11/extensions/Xfixes.h>
Expand Down