Repository navigation
gpsprot: derive 3D position accuracy from horizontal and vertical - #521
Merged
Merged
Conversation
Since satpulsed started configuring geodetic rather than ECEF position output, receivers such as u-blox report only horizontal and vertical position accuracy, so the web interface and Prometheus lost the 3D accuracy they showed before. Accuracy has a new FillDerived method that sets Pos to sqrt(Hor^2 + Vert^2) when Pos is unset and both Hor and Vert are set. The dispatcher calls it on each NavEpoch after the message is written to the event log, so observers get the derived value while the event log keeps only what the receiver reported. Fixes #343
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Move the Accuracy.FillDerived call next to the PVMsgBundle.FillDerived call and shorten its comment. TimeTicker.NavEpoch does not look at the message, so the order does not matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since satpulsed started configuring geodetic rather than ECEF position
output, receivers such as u-blox report only horizontal and vertical
position accuracy, so the web interface and Prometheus lost the 3D
accuracy they showed before.
Accuracy has a new FillDerived method that sets Pos to
sqrt(Hor^2 + Vert^2) when Pos is unset and both Hor and Vert are set.
The dispatcher calls it on each NavEpoch after the message is written
to the event log, so observers get the derived value while the event
log keeps only what the receiver reported.
Fixes #343