Repository navigation
Conversation
The caster's stream messages went through the shared caster logger, so with several rovers on one mountpoint a write error or a queue-full warning could not be matched to a client; only the queue-full warning named the mountpoint. serveStream now tags a logger with the client's remote address and the mountpoint and passes it down to streamLoop and queue, so every message about a stream says which one it is.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The caster's stream messages went through the shared caster logger, so with several rovers on one mountpoint a write error or a queue-full warning could not be matched to a client. Only the queue-full warning named the mountpoint.
serveStreamnow tags a logger with the client's remote address and the mountpoint and passes it down tostreamLoopandqueue, so every message about a stream carries both. The queue-full warning drops its ownmountpointfield, which the tag now provides. This is the caster counterpart of #512 for the proxy.Stacked on #514.
make testand the ntrip smoke tests pass (ntrip/rtklibskipped: nostr2strhere).