Skip to content

fix: use getattr for safe access to request.axes_attempt_time #1449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muhamedfazalps wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: use getattr for safe access to request.axes_attempt_time #1449

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion axes/attempts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def get_cool_off_threshold(request: Optional[HttpRequest] = None) -> datetime:
"Cool off threshold can not be calculated with settings.AXES_COOLOFF_TIME set to None"
)

attempt_time = request.axes_attempt_time # type: ignore[union-attr]
attempt_time = getattr(request, "axes_attempt_time", None)
if attempt_time is None:
return now() - cool_off
return attempt_time - cool_off