Skip multiprocess tests without a usable keyring backend - #761
Open
l46983284-cpu wants to merge 1 commit into
Open
Skip multiprocess tests without a usable keyring backend#761l46983284-cpu wants to merge 1 commit into
l46983284-cpu wants to merge 1 commit into
Conversation
When only the fail backend is available (no recommended backend or keyrings.alt), child processes raise NoKeyringError and the suite fails. Skip those tests instead of requiring optional packages. Fixes jaraco#737 Signed-off-by: Alex Chen <l46983284@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multiprocess tests call
keyring.get_passwordin a child process. When no recommended backend (and nokeyrings.alt) is available, the selected backend iskeyring.backends.fail.Keyringand the child exits non-zero withNoKeyringError.Skip those tests when the selected keyring is the fail backend, with a reason that points at installing a recommended backend or
keyrings.alt. Keep the existing Linux#410xfail.Test plan
python3 -m pytest -q tests/test_multiprocess.py→ 2 skipped, exit 0keyrings.altfor a green runFixes #737