Skip to content

Update max & min tests for jank #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shantanu-sardesai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update max & min tests for jank #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions test/clojure/core_test/max.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,12 @@
(is (= ##Inf (max 1 2 3 4 5 ##Inf)))

(is (NaN? (max ##NaN 1)))
(is (NaN? (max 1 ##NaN)))
(is (NaN? (max 1 2 3 4 ##NaN)))
(is (NaN? (max ##-Inf ##NaN ##Inf)))
#?@(:jank [(is 1 (= (max 1 ##NaN)))

@jeaye jeaye Aug 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave a comment next to any jank-specific differences to explain why it's different. Follow jank's practices about what makes a good comment.

(is 4 (= (max 1 2 3 4 ##NaN)))
(is ##Inf (= (max ##-Inf ##NaN ##Inf)))]
:default [(is (NaN? (max 1 ##NaN)))
(is (NaN? (max 1 2 3 4 ##NaN)))
(is (NaN? (max ##-Inf ##NaN ##Inf)))])
(is (NaN? (max ##NaN)))

#?@(:lpy
Expand Down
6 changes: 4 additions & 2 deletions test/clojure/core_test/min.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,12 @@
(is (= ##-Inf (min 1 2 3 4 5 ##-Inf)))
(is (= 1 (min 1 2 3 4 5 ##Inf)))

#?@(:jank [(is (= 1 (min 1 ##NaN)))
(is (= ##Inf (min ##-Inf ##NaN ##Inf)))]
:default [(is (NaN? (min 1 ##NaN)))
(is (NaN? (min ##-Inf ##NaN ##Inf)))])
(is (NaN? (min ##NaN 1)))
(is (NaN? (min 1 ##NaN)))
(is (NaN? (min 1 2 3 4 ##NaN)))
(is (NaN? (min ##-Inf ##NaN ##Inf)))
(is (NaN? (min ##NaN)))

#?@(:lpy
Expand Down
Loading