Handle trigger breakpoints across process threads - #387
Draft
namtran1812 wants to merge 1 commit into
Draft
Conversation
Signed-off-by: namtran1812 <158846154+namtran1812@users.noreply.github.com>
Author
|
Draft for validation: DCO is passing, but the Linux build workflow is currently blocked before any jobs are created. I’ll keep this in draft until CI and end-to-end multithreaded perf validation are complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix trigger breakpoints so they can fire from worker threads when magic-trace is attached to a multithreaded process.
Fixes #274.
Problem
The existing trigger implementation creates a hardware breakpoint only for the head PID/TID. Since
perf_event_openbreakpoints are task-specific, a trigger such asmagic_trace_stop_indicator()can work from the main thread but be missed when called from a worker thread.Implementation
/proc/<pid>/taskTrigger_breakpointabstraction for breakpoint lifecycle and Async FD monitoringValidation
dune build @fmtpasses locallygit diff --checkpasses locallyEnd-to-end perf breakpoint behavior requires Linux validation, so this is being opened as a draft.