chore: upgrade Expo SDK 55 → 57 and React Native 0.83 → 0.86#54
Open
jakejarvis wants to merge 7 commits into
Open
chore: upgrade Expo SDK 55 → 57 and React Native 0.83 → 0.86#54jakejarvis wants to merge 7 commits into
jakejarvis wants to merge 7 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #54 +/- ##
=======================================
Coverage 68.82% 68.82%
=======================================
Files 30 30
Lines 2512 2512
Branches 809 809
=======================================
Hits 1729 1729
Misses 651 651
Partials 132 132 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
4 issues found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/public-api/package.json">
<violation number="1" location="apps/public-api/package.json:15">
P2: `@hono/zod-validator` 0.8.0 includes documented type-level breaking changes for the no-hook overload: the failure response type is now wider and intersected with `Response`. All four `zValidator()` calls in `src/app.ts` use the no-hook form, so these changes apply. Run `bun run check-types` to confirm no type errors emerge from this upgrade. If they do, pass an explicit hook callback or downgrade to 0.7.6.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
jakejarvis
added
the
eas-build
…p avatar aria-label - Move iOS `deploymentTarget` from expo-build-properties plugin config to top-level `ios` field in app.json, removing the now-unnecessary `expo-build-properties` dependency - Upgrade `@sentry/react-native` from ~7.11.0 to ~8.17.2 - Remove redundant `aria-label` from avatar upload button in web settings
There was a problem hiding this comment.
1 issue found across 9 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".oxlintrc.json">
<violation number="1" location=".oxlintrc.json:28">
P2: The `@e18e/eslint-plugin` JS plugin and all its `e18e/prefer-*` rules are being removed. Several have native Oxlint equivalents that are not being enabled, such as `typescript/prefer-nullish-coalescing`, `eslint/prefer-includes`, `eslint/prefer-object-has-own`, `unicorn/prefer-array-some`, `unicorn/prefer-at`, and `unicorn/prefer-date-now`. Consider enabling those to maintain the code-quality enforcement that was previously provided at error level. No Oxlint equivalent exists for other removed rules like `e18e/prefer-array-fill`, `e18e/prefer-array-from-map`, and `e18e/prefer-regex-test` which are silently dropped.</violation>
</file>
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
| @@ -1,7 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
P2: The @e18e/eslint-plugin JS plugin and all its e18e/prefer-* rules are being removed. Several have native Oxlint equivalents that are not being enabled, such as typescript/prefer-nullish-coalescing, eslint/prefer-includes, eslint/prefer-object-has-own, unicorn/prefer-array-some, unicorn/prefer-at, and unicorn/prefer-date-now. Consider enabling those to maintain the code-quality enforcement that was previously provided at error level. No Oxlint equivalent exists for other removed rules like e18e/prefer-array-fill, e18e/prefer-array-from-map, and e18e/prefer-regex-test which are silently dropped.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At .oxlintrc.json, line 28:
<comment>The `@e18e/eslint-plugin` JS plugin and all its `e18e/prefer-*` rules are being removed. Several have native Oxlint equivalents that are not being enabled, such as `typescript/prefer-nullish-coalescing`, `eslint/prefer-includes`, `eslint/prefer-object-has-own`, `unicorn/prefer-array-some`, `unicorn/prefer-at`, and `unicorn/prefer-date-now`. Consider enabling those to maintain the code-quality enforcement that was previously provided at error level. No Oxlint equivalent exists for other removed rules like `e18e/prefer-array-fill`, `e18e/prefer-array-from-map`, and `e18e/prefer-regex-test` which are silently dropped.</comment>
<file context>
@@ -26,23 +25,7 @@
- "e18e/prefer-static-regex": "error",
- "e18e/prefer-timer-args": "error",
- "e18e/prefer-url-canparse": "error"
+ "react/rules-of-hooks": "error"
},
"ignorePatterns": ["node_modules", "dist", "build", "docs", "**/routeTree.gen.ts"]
</file context>
…s card, and sort menu components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Upgrade Expo SDK 55 → 57 and
react-native0.83 → 0.86 across the monorepo, migrate navigation toexpo-router/react-navigation, replace native menus with@expo/ui, removeexpo-build-properties, and include targeted a11y/perf/test cleanups.Dependencies
expoand modules → 57;react-native→ 0.86;expo-router→ ~57; add@expo/uiand@expo/material-symbols;@sentry/react-native→ ~8.18 (excluded from Expo auto-install);posthog-react-native→ 4.55.0.zeegoand@react-native-menu/menu; move iOS deployment target toapp.json(ios.deploymentTarget: "16.4"); removeexpo-build-properties.@tanstack/*,hono(4.12.28),croner(10.0.2-dev.3),vite(8.1.3),next(16.2.10),tailwind*(4.3.2);bun→ 1.3.14; docs updated to latestfumadocs-*.claude.ymlandclaude-code-review.yml; simplify.oxlintrc(drop@e18e/eslint-plugin; allow__APP_VERSION__,__GIT_COMMIT_SHA__inno-underscore-dangle).Refactors
zeegodropdowns with@expo/uiMenuViewand use@expo/material-symbolson Android; remove menu-open haptic triggers.expo-router/react-navigationThemeProviderand header APIs; extractheaderRight/unstable_headerRightItemshelpers for stability.drizzleinit.createOpenAPIPagewith server-provided OpenAPI payload.aria-labels, remove redundantroles, usearia-pressedfor star rating, improve input-group focusing, fasteruseIsMobileinit, smoother season accordion.Written for commit 5db6a44. Summary will update on new commits.