Compiler backend crashes with a overflow if you have more than 254 arguments

[Erk-]

I believe the issue happens here:

redscript/crates/compiler/backend/src/assemble.rs

Line 663 in 3ca666c

for (arg, i) in args.iter().zip(0u8..) {

I am not quite sure what happens here when compiled without overflow protection but it will mean that value of i overflows back to 0 which I assume could cause some issues further down the chain.

MRE:

Details

func ManyArgs(x0: Int32, x1: Int32, x2: Int32, x3: Int32, x4: Int32, x5: Int32, x6: Int32, x7: Int32, x8: Int32, x9: Int32, x10: Int32, x11: Int32, x12: Int32, x13: Int32, x14: Int32, x15: Int32, x16: Int32, x17: Int32, x18: Int32, x19: Int32, x20: Int32, x21: Int32, x22: Int32, x23: Int32, x24: Int32, x25: Int32, x26: Int32, x27: Int32, x28: Int32, x29: Int32, x30: Int32, x31: Int32, x32: Int32, x33: Int32, x34: Int32, x35: Int32, x36: Int32, x37: Int32, x38: Int32, x39: Int32, x40: Int32, x41: Int32, x42: Int32, x43: Int32, x44: Int32, x45: Int32, x46: Int32, x47: Int32, x48: Int32, x49: Int32, x50: Int32, x51: Int32, x52: Int32, x53: Int32, x54: Int32, x55: Int32, x56: Int32, x57: Int32, x58: Int32, x59: Int32, x60: Int32, x61: Int32, x62: Int32, x63: Int32, x64: Int32, x65: Int32, x66: Int32, x67: Int32, x68: Int32, x69: Int32, x70: Int32, x71: Int32, x72: Int32, x73: Int32, x74: Int32, x75: Int32, x76: Int32, x77: Int32, x78: Int32, x79: Int32, x80: Int32, x81: Int32, x82: Int32, x83: Int32, x84: Int32, x85: Int32, x86: Int32, x87: Int32, x88: Int32, x89: Int32, x90: Int32, x91: Int32, x92: Int32, x93: Int32, x94: Int32, x95: Int32, x96: Int32, x97: Int32, x98: Int32, x99: Int32, x100: Int32, x101: Int32, x102: Int32, x103: Int32, x104: Int32, x105: Int32, x106: Int32, x107: Int32, x108: Int32, x109: Int32, x110: Int32, x111: Int32, x112: Int32, x113: Int32, x114: Int32, x115: Int32, x116: Int32, x117: Int32, x118: Int32, x119: Int32, x120: Int32, x121: Int32, x122: Int32, x123: Int32, x124: Int32, x125: Int32, x126: Int32, x127: Int32, x128: Int32, x129: Int32, x130: Int32, x131: Int32, x132: Int32, x133: Int32, x134: Int32, x135: Int32, x136: Int32, x137: Int32, x138: Int32, x139: Int32, x140: Int32, x141: Int32, x142: Int32, x143: Int32, x144: Int32, x145: Int32, x146: Int32, x147: Int32, x148: Int32, x149: Int32, x150: Int32, x151: Int32, x152: Int32, x153: Int32, x154: Int32, x155: Int32, x156: Int32, x157: Int32, x158: Int32, x159: Int32, x160: Int32, x161: Int32, x162: Int32, x163: Int32, x164: Int32, x165: Int32, x166: Int32, x167: Int32, x168: Int32, x169: Int32, x170: Int32, x171: Int32, x172: Int32, x173: Int32, x174: Int32, x175: Int32, x176: Int32, x177: Int32, x178: Int32, x179: Int32, x180: Int32, x181: Int32, x182: Int32, x183: Int32, x184: Int32, x185: Int32, x186: Int32, x187: Int32, x188: Int32, x189: Int32, x190: Int32, x191: Int32, x192: Int32, x193: Int32, x194: Int32, x195: Int32, x196: Int32, x197: Int32, x198: Int32, x199: Int32, x200: Int32, x201: Int32, x202: Int32, x203: Int32, x204: Int32, x205: Int32, x206: Int32, x207: Int32, x208: Int32, x209: Int32, x210: Int32, x211: Int32, x212: Int32, x213: Int32, x214: Int32, x215: Int32, x216: Int32, x217: Int32, x218: Int32, x219: Int32, x220: Int32, x221: Int32, x222: Int32, x223: Int32, x224: Int32, x225: Int32, x226: Int32, x227: Int32, x228: Int32, x229: Int32, x230: Int32, x231: Int32, x232: Int32, x233: Int32, x234: Int32, x235: Int32, x236: Int32, x237: Int32, x238: Int32, x239: Int32, x240: Int32, x241: Int32, x242: Int32, x243: Int32, x244: Int32, x245: Int32, x246: Int32, x247: Int32, x248: Int32, x249: Int32, x250: Int32, x251: Int32, x252: Int32, x253: Int32, x254: Int32, x255: Int32) -> Int32 { return x0; }

func Test() {
  let x0 = 1; let x1 = 1; let x2 = 1; let x3 = 1; let x4 = 1; let x5 = 1; let x6 = 1; let x7 = 1; let x8 = 1; let x9 = 1; let x10 = 1; let x11 = 1; let x12 = 1; let x13 = 1; let x14 = 1; let x15 = 1; let x16 = 1; let x17 = 1; let x18 = 1; let x19 = 1; let x20 = 1; let x21 = 1; let x22 = 1; let x23 = 1; let x24 = 1; let x25 = 1; let x26 = 1; let x27 = 1; let x28 = 1; let x29 = 1; let x30 = 1; let x31 = 1; let x32 = 1; let x33 = 1; let x34 = 1; let x35 = 1; let x36 = 1; let x37 = 1; let x38 = 1; let x39 = 1; let x40 = 1; let x41 = 1; let x42 = 1; let x43 = 1; let x44 = 1; let x45 = 1; let x46 = 1; let x47 = 1; let x48 = 1; let x49 = 1; let x50 = 1; let x51 = 1; let x52 = 1; let x53 = 1; let x54 = 1; let x55 = 1; let x56 = 1; let x57 = 1; let x58 = 1; let x59 = 1; let x60 = 1; let x61 = 1; let x62 = 1; let x63 = 1; let x64 = 1; let x65 = 1; let x66 = 1; let x67 = 1; let x68 = 1; let x69 = 1; let x70 = 1; let x71 = 1; let x72 = 1; let x73 = 1; let x74 = 1; let x75 = 1; let x76 = 1; let x77 = 1; let x78 = 1; let x79 = 1; let x80 = 1; let x81 = 1; let x82 = 1; let x83 = 1; let x84 = 1; let x85 = 1; let x86 = 1; let x87 = 1; let x88 = 1; let x89 = 1; let x90 = 1; let x91 = 1; let x92 = 1; let x93 = 1; let x94 = 1; let x95 = 1; let x96 = 1; let x97 = 1; let x98 = 1; let x99 = 1; let x100 = 1; let x101 = 1; let x102 = 1; let x103 = 1; let x104 = 1; let x105 = 1; let x106 = 1; let x107 = 1; let x108 = 1; let x109 = 1; let x110 = 1; let x111 = 1; let x112 = 1; let x113 = 1; let x114 = 1; let x115 = 1; let x116 = 1; let x117 = 1; let x118 = 1; let x119 = 1; let x120 = 1; let x121 = 1; let x122 = 1; let x123 = 1; let x124 = 1; let x125 = 1; let x126 = 1; let x127 = 1; let x128 = 1; let x129 = 1; let x130 = 1; let x131 = 1; let x132 = 1; let x133 = 1; let x134 = 1; let x135 = 1; let x136 = 1; let x137 = 1; let x138 = 1; let x139 = 1; let x140 = 1; let x141 = 1; let x142 = 1; let x143 = 1; let x144 = 1; let x145 = 1; let x146 = 1; let x147 = 1; let x148 = 1; let x149 = 1; let x150 = 1; let x151 = 1; let x152 = 1; let x153 = 1; let x154 = 1; let x155 = 1; let x156 = 1; let x157 = 1; let x158 = 1; let x159 = 1; let x160 = 1; let x161 = 1; let x162 = 1; let x163 = 1; let x164 = 1; let x165 = 1; let x166 = 1; let x167 = 1; let x168 = 1; let x169 = 1; let x170 = 1; let x171 = 1; let x172 = 1; let x173 = 1; let x174 = 1; let x175 = 1; let x176 = 1; let x177 = 1; let x178 = 1; let x179 = 1; let x180 = 1; let x181 = 1; let x182 = 1; let x183 = 1; let x184 = 1; let x185 = 1; let x186 = 1; let x187 = 1; let x188 = 1; let x189 = 1; let x190 = 1; let x191 = 1; let x192 = 1; let x193 = 1; let x194 = 1; let x195 = 1; let x196 = 1; let x197 = 1; let x198 = 1; let x199 = 1; let x200 = 1; let x201 = 1; let x202 = 1; let x203 = 1; let x204 = 1; let x205 = 1; let x206 = 1; let x207 = 1; let x208 = 1; let x209 = 1; let x210 = 1; let x211 = 1; let x212 = 1; let x213 = 1; let x214 = 1; let x215 = 1; let x216 = 1; let x217 = 1; let x218 = 1; let x219 = 1; let x220 = 1; let x221 = 1; let x222 = 1; let x223 = 1; let x224 = 1; let x225 = 1; let x226 = 1; let x227 = 1; let x228 = 1; let x229 = 1; let x230 = 1; let x231 = 1; let x232 = 1; let x233 = 1; let x234 = 1; let x235 = 1; let x236 = 1; let x237 = 1; let x238 = 1; let x239 = 1; let x240 = 1; let x241 = 1; let x242 = 1; let x243 = 1; let x244 = 1; let x245 = 1; let x246 = 1; let x247 = 1; let x248 = 1; let x249 = 1; let x250 = 1; let x251 = 1; let x252 = 1; let x253 = 1; let x254 = 1; let x255 = 1; let x256 = 1;
  
  ManyArgs(x0, x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11, x12, x13, x14, x15, x16, x17, x18, x19, x20, x21, x22, x23, x24, x25, x26, x27, x28, x29, x30, x31, x32, x33, x34, x35, x36, x37, x38, x39, x40, x41, x42, x43, x44, x45, x46, x47, x48, x49, x50, x51, x52, x53, x54, x55, x56, x57, x58, x59, x60, x61, x62, x63, x64, x65, x66, x67, x68, x69, x70, x71, x72, x73, x74, x75, x76, x77, x78, x79, x80, x81, x82, x83, x84, x85, x86, x87, x88, x89, x90, x91, x92, x93, x94, x95, x96, x97, x98, x99, x100, x101, x102, x103, x104, x105, x106, x107, x108, x109, x110, x111, x112, x113, x114, x115, x116, x117, x118, x119, x120, x121, x122, x123, x124, x125, x126, x127, x128, x129, x130, x131, x132, x133, x134, x135, x136, x137, x138, x139, x140, x141, x142, x143, x144, x145, x146, x147, x148, x149, x150, x151, x152, x153, x154, x155, x156, x157, x158, x159, x160, x161, x162, x163, x164, x165, x166, x167, x168, x169, x170, x171, x172, x173, x174, x175, x176, x177, x178, x179, x180, x181, x182, x183, x184, x185, x186, x187, x188, x189, x190, x191, x192, x193, x194, x195, x196, x197, x198, x199, x200, x201, x202, x203, x204, x205, x206, x207, x208, x209, x210, x211, x212, x213, x214, x215, x216, x217, x218, x219, x220, x221, x222, x223, x224, x225, x226, x227, x228, x229, x230, x231, x232, x233, x234, x235, x236, x237, x238, x239, x240, x241, x242, x243, x244, x245, x246, x247, x248, x249, x250, x251, x252, x253, x254, x255);
}