Changes for new iron version 0.7 with hyper 0.12#75
Open
zgtm wants to merge 1 commit into
Open
Conversation
zgtm
commented
Feb 11, 2019
zgtm
left a comment
zgtm
left a comment
Author
There was a problem hiding this comment.
Apparently somewhere something goes still wrong when reading GET query parameters.
| impl plugin::Plugin<Request> for UrlEncodedQuery { | ||
| type Error = UrlDecodingError; | ||
|
|
||
| fn eval(req: &mut Request) -> QueryResult { |
Author
There was a problem hiding this comment.
req.url.query() seems to fail or something, at least in my testrun it did not give me any data …
Author
|
Okay, PR iron/iron#604 fixes reading query strings form the response, so everything should work here, after it is merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adapts to the changed types in
iron(StatusCode,Request).