This repository was archived by the owner on Mar 10, 2020. It is now read-only.
[WIP] feat: make ipfs add --nocopy works#564
Open
MichaelMure wants to merge 1 commit into
Open
Conversation
provide the Abspath header in the stream for file so the filestore can find the actual file on disk It works but I still get errors like 'Error: expected protobuf dag node' sometimes
Contributor
|
The goal of this PR will start working with the update for #522 That said, I'm not sure what the code in your PR is trying to achieve. Could you clarify? |
Contributor
|
@MichaelMure this PR is now unblocked because options are correctly passed. Wanna look at it again? |
daviddias
suggested changes
Oct 30, 2017
daviddias
left a comment
daviddias
left a comment
Contributor
There was a problem hiding this comment.
Needs tests and documentation
daviddias
changed the title
alanshaw
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/ipfs/js-ipfs-api/issues/562
Provide the Abspath header in the stream for files so the filestore can find the actual file on disk.
It works but I still get errors like 'Error: expected protobuf dag node' for some files but not for some others.
@kevina, any ideas ?