This repository was archived by the owner on Mar 10, 2020. It is now read-only.
feat: meta for ipfs.get#1235
Open
alanshaw wants to merge 3 commits into
Open
Conversation
3 tasks
alanshaw
pushed a commit
to ipfs/js-ipfs
that referenced
this pull request
Feb 9, 2020
Pack file `mtime` and `mode` if set Depends on: * [ ] #2758 * [ ] ipfs-inactive/js-ipfs-http-client#1235
achingbrain
suggested changes
Feb 10, 2020
| for await (const { header, body } of extractor(toIterable(res.body))) { | ||
| const file = { | ||
| path: header.name, | ||
| mtime: { secs: Math.floor(header.mtime.getTime() / 1000) }, |
Collaborator
There was a problem hiding this comment.
Can this support the nsecs mtime component too? At the moment I think it's going to throw away anything that isn't a whole second.
Collaborator
|
Could you merge this into ipfs/js-ipfs#2759 please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract
mtimeandmodeDepends on: