Skip to content

ITM-6: Add missing SSO credentials to hidden Team Chat widget - #62

Closed
karenndegwa6-creator wants to merge 1 commit into
mainfrom
itm-6-fix-team-chat-sso
Closed

ITM-6: Add missing SSO credentials to hidden Team Chat widget#62
karenndegwa6-creator wants to merge 1 commit into
mainfrom
itm-6-fix-team-chat-sso

Conversation

@karenndegwa6-creator

@karenndegwa6-creator karenndegwa6-creator commented Jul 22, 2026

Copy link
Copy Markdown

Fixes iotum/selenium-nodejs#513.

The hidden Team Chat widget in the Tabbed Dashboard sample is created without the sso: { token, hostId } block that the main dashboard widget receives via the shared createWidget() helper. Without credentials, its iframe hits conf/loading anonymously, redirects to login/login, and hangs indefinitely, so dashboard.READY never fires and the Team Chat tab stays disabled forever.

This adds the missing sso block to the Team widget's Callbridge.Dashboard constructor call, matching the main widget. token and hostId are already in scope in this function (same as used elsewhere in renderWidget).

Verified the root cause live against the deployed sample app (iframe/network inspection) before making this change — details in iotum/selenium-nodejs#513.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the Tabbed Dashboard sample’s hidden Team Chat widget initialization so it receives the same SSO credentials as the main dashboard widget, preventing the chat iframe from loading anonymously and hanging (which previously kept dashboard.READY from firing and the Team Chat tab disabled).

Changes:

  • Pass sso: { token, hostId } into the hidden Team Chat Callbridge.Dashboard constructor to match the main widget’s authenticated setup.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@karenndegwa6-creator

Copy link
Copy Markdown
Author

Closing this without merging. Retested the Team Chat hang on the live unpatched main branch using the ucaas-tech.callbridge.rocks domain (instead of iotum.callbridge.rocks) and it loaded fine on the very first click, no hang, no fix applied. That points to the original issue being caused by testing/logging in against the wrong/misconfigured domain rather than a real gap in this widget's SSO wiring, so this fix looks like it's patching a problem that doesn't actually reproduce under normal conditions.

Full writeup in iotum/selenium-nodejs#513. Will reopen this if the hang turns up again on a correctly-configured domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants