feat: add volume performance classes to volume --type completion#680
Draft
mimihalescu wants to merge 2 commits into
Draft
feat: add volume performance classes to volume --type completion#680mimihalescu wants to merge 2 commits into
mimihalescu wants to merge 2 commits into
Conversation
Add ESSENTIAL, BALANCED and PERFORMANCE to the volume create --type shell completion. Also fix the completion being registered on the wrong flag (--licence-type) so it now completes on --type.
|
| _ = cmd.Command.RegisterFlagCompletionFunc(cloudapiv6.ArgLicenceType, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
| return []string{"HDD", "SSD", "SSD Standard", "SSD Premium"}, cobra.ShellCompDirectiveNoFileComp | ||
| _ = cmd.Command.RegisterFlagCompletionFunc(constants.FlagType, func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) { | ||
| return []string{"HDD", "SSD", "SSD Standard", "SSD Premium", "ESSENTIAL", "BALANCED", "PERFORMANCE"}, cobra.ShellCompDirectiveNoFileComp |
Contributor
There was a problem hiding this comment.
If the API team means to have most of the users use the new types, I would move them in front of the HDD / SSD choices, else 90+% of the users will use HDD / SSD
Suggested change
| return []string{"HDD", "SSD", "SSD Standard", "SSD Premium", "ESSENTIAL", "BALANCED", "PERFORMANCE"}, cobra.ShellCompDirectiveNoFileComp | |
| return []string{"ESSENTIAL", "BALANCED", "PERFORMANCE", "HDD", "SSD", "SSD Standard", "SSD Premium"}, cobra.ShellCompDirectiveNoFileComp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the new volume performance classes
ESSENTIAL,BALANCEDandPERFORMANCEto thevolume create --typeshell completion. Also fixes a pre-existing bug where this completion was registered on--licence-typeinstead of--type, so--typehad no completion at all.Draft until the classes are live on the API.