feat(cli): add migrator functionality for adopting UIScene - #8544
Open
theproducer wants to merge 24 commits into
Open
feat(cli): add migrator functionality for adopting UIScene#8544theproducer wants to merge 24 commits into
theproducer wants to merge 24 commits into
Conversation
This was referenced Jul 29, 2026
theproducer
marked this pull request as ready for review
July 29, 2026 20:37
ItsChaceD
self-requested a review
July 29, 2026 20:47
ItsChaceD
requested changes
Jul 29, 2026
| const state = classify(signals); | ||
|
|
||
| switch (state) { | ||
| case 'ineligible': |
Contributor
There was a problem hiding this comment.
Can we ever reach the ineligible case?
Maybe we can do something like:
const state = existsSync(config.ios.platformDirAbs) ? classify(signals) : 'ineligible';
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CLI migrator to assist with migrating pre-UIScene Capacitor projects to adopting UIScene: #8536
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments