Skip to content

fix(android): cap console message length before String.format to prevent OOM (#8532) #8533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
codebyshoaib wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix(android): cap console message length before String.format to prevent OOM (#8532) #8533

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion android/capacitor/src/main/java/com/getcapacitor/BridgeWebChromeClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,11 @@
*/
public class BridgeWebChromeClient extends WebChromeClient {

// Cap the console message length before formatting so that a very large JS
// log argument (e.g. a serialized IndexedDB row or an axios error/response)
// cannot OutOfMemoryError the bridge on low-RAM devices. See #8532.
private static final int MAX_CONSOLE_MESSAGE_LENGTH = 8 * 1024;

private interface PermissionListener {
void onPermissionSelect(Boolean isGranted);
}
Expand Down Expand Up @@ -427,11 +432,15 @@ private String[] getValidTypes(String[] currentTypes) {
public boolean onConsoleMessage(ConsoleMessage consoleMessage) {
String tag = Logger.tags("Console");
if (consoleMessage.message() != null && isValidMsg(consoleMessage.message())) {
String message = consoleMessage.message();
if (message.length() > MAX_CONSOLE_MESSAGE_LENGTH) {
message = message.substring(0, MAX_CONSOLE_MESSAGE_LENGTH) + "… [truncated]";
}
String msg = String.format(
"File: %s - Line %d - Msg: %s",
consoleMessage.sourceId(),
consoleMessage.lineNumber(),
consoleMessage.message()
message
);
String level = consoleMessage.messageLevel().name();
if ("ERROR".equalsIgnoreCase(level)) {
Expand Down