[GSoC 2026] chatbot: default analyze_observable to a curated playbook + forbid placeholder names - #3881
Open
berardifra wants to merge 2 commits into
Open
[GSoC 2026] chatbot: default analyze_observable to a curated playbook + forbid placeholder names#3881berardifra wants to merge 2 commits into
berardifra wants to merge 2 commits into
Conversation
… + forbid placeholder names — Refs #3880 A1: when the model names neither a playbook nor analyzers, analyze_observable now resolves the curated FREE_TO_USE_ANALYZERS playbook (when visible, applicable and enabled) instead of dead-ending on 'No Analyzers and Connectors can be run after filtering'. Falls back to an actionable error listing the applicable visible playbooks. The plan carries a 'reason' explaining the choice, the model is told to surface it in the confirmation, and the pending record stores the resolved playbook so confirm re-validates the same plan. A2: a [Rules] line tells the model to copy analyzer/playbook/job names verbatim and never emit bracketed placeholders like [Analyzer 1].
mlodic
approved these changes
Jul 23, 2026
…complexity (DeepSource PY-R1000)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #3880
Two chatbot bug fixes reported by @mlodic (see #3880).
A1 — analyze_observable no longer dead-ends on "No Analyzers and Connectors can be run after filtering"
when the user names neither a playbook nor analyzers: it defaults to the curated FREE_TO_USE_ANALYZERS playbook
(visible/applicable/enabled), or returns an actionable error listing pickable playbooks. The plan carries a
reason, the model is instructed to surface it, and the pending stores the resolved playbook so confirmre-validates the same plan.
A2 — a [Rules] line forbids bracketed placeholders like [Analyzer 1] and requires verbatim names.
Multi-tenancy: playbook resolution is scoped to
visible_for_user. Tests: 5 new analyze_observable cases + 1prompt assertion; full chatbot suite green (181/181). No dependency changes.