Skip to content

apply_patches CMakeFunction shouldn't checkout existing branch #215

Description

@PawelJurek

Function "apply_patches" checks out the branch, where patches are applied if it already exists:

else() # The target branch already exists

I think the logic here might lead to unexpected issues, e.g. if you download new opencl-clang commit, where a new patch is introduced, it won't be applied if the branch is not manually deleted.

Maybe the function should delete the branch at first step?

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions