[DDI] Fix debug assert to check source surface bo in MediaSurfaceToMosResource#2012
Open
XinfengZhang wants to merge 1 commit into
Open
[DDI] Fix debug assert to check source surface bo in MediaSurfaceToMosResource#2012XinfengZhang wants to merge 1 commit into
XinfengZhang wants to merge 1 commit into
Conversation
…sResource DdiMedia_MediaSurfaceToMosResource asserted on the destination mosResource->bo, which is not yet populated at that point, instead of the source mediaSurface->bo. This fired on valid usage in debug builds. Assert on mediaSurface->bo, consistent with DdiMedia_MediaBufferToMosResource. Fixes: intel#1724 Signed-off-by: Carl.Zhang <carl.zhang@intel.com>
MicroYY
approved these changes
Jul 10, 2026
XinfengZhang
added
verifying
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DdiMedia_MediaSurfaceToMosResourceasserted on the destinationmosResource->bo, which is not yet populated at that point, instead of thesource
mediaSurface->bo. With debug asserts enabled this fired on validusage. The assert now checks
mediaSurface->bo, consistent with the siblingDdiMedia_MediaBufferToMosResourcewhich assertsmediaBuffer->bo.Issue
Fixes #1724