Repository navigation
fix(migtd): apply log level settings to spdmlib - #1052
Merged
Merged
Conversation
sgrams
force-pushed
the
fix/spdmlib-release-logging
branch
from
September 25, 2026 11:25
2d73baf to
dfca245
Compare
sgrams
marked this pull request as draft
September 25, 2026 11:30
sgrams
changed the title
sgrams
force-pushed
the
fix/spdmlib-release-logging
branch
2 times, most recently
from
October 2, 2026 14:34
5e53f13 to
0e85216
Compare
Use shared log crate features to apply the selected log level to MigTD and spdmlib without a custom SPDM dependency patch. Honor explicit off settings and the documented release-off and debug-info defaults. Cap debug and trace requests at info in both build profiles. Enforce the same ceiling in native and VMM logger initialization, log-area requests, backend filtering, and direct buffer writes so debug and trace records cannot be emitted. Cover all log-level selections and profile defaults, and verify debug/trace suppression while preserving info records in provisional and shared log buffers. Assisted-by: GitHub Copilot:GPT-6 Astra Signed-off-by: Stanislaw Grams <stanislaw.grams@intel.com>
sgrams
force-pushed
the
fix/spdmlib-release-logging
branch
from
October 2, 2026 15:08
0e85216 to
acb4152
Compare
sgrams
marked this pull request as ready for review
October 7, 2026 09:40
MichalTarnacki
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply MigTD's selected log level to
spdmlibthrough their sharedlogcrate, without a custom SPDM patch or fork.--log-level offinstead of overriding it toinfo.offfor release builds andinfofor debug builds.error,warn,info,debug, andtracesettings in both profiles.Validation
cargo test -p xtask log_level_features: passed, covering all six levels and the default in both profiles.cargo fmt -p xtask -- --check: passed.git diff --check: passed.spdmlibshare the samelogpackage and receive the selected off/info features for both profiles.Assisted-by: GitHub Copilot:GPT-6 Astra