Fix the memory leak issue in the lz_codecs.cpp file - #318
Open
wu-zhao-min wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description：The lzbench_libdeflate_decompress function in the lz_codecs.cpp file allocates the decompressor using libdeflate_alloc_decompressor(), but it does not call libdeflate_free_decompressor() to release it on either of the two exit paths.
Hazard statement：During the stress testing, each decompression call will leak a decompressor object. Long-term stress testing will significantly consume memory.
Repair solution: Add release calls before both return paths.