feat(inputs.vsphere): Allow adding custom properties as fields by tguenneguez · Pull Request #19161 · influxdata/telegraf

tguenneguez · 2026-06-25T07:23:45Z

Summary

Add the capabilitie to collecte properties of elements.

For sample :

host :
- summary.runtime.powerState
- summary.overallStatus
- summary.runtime.inMaintenanceMode
- summary.runtime.connectionState
vm :
- runtime.powerState
cluster :
- overallStatus
- configuration.drsConfig.enabled
datastore :
- summary.accessible
resource_pool :
- overallStatus

This change collect data for VM Power Off. There was no information about this subtility.

Checklist

No AI generated code was used in this PR
AI generated code used in this PR follows the InfluxData Policy on AI-Generated Code Contributions

Related issues

resolves #18858

srebhan · 2026-07-03T09:10:04Z

Thanks for your contribution @tguenneguez! Can you please check and fix the linter issues!? Furthermore, you can't check "I've used no AI" and "I've used AI" at the same time. :-) Please fix the checkboxes in the PR description. :-)

tguenneguez · 2026-07-03T09:24:53Z

Yes, I have seen it, but I do lot off think in the same time so, i change when I have time.
I think it will be good.

telegraf-tiger · 2026-07-03T09:44:26Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB	. RPM	. TAR . GZ	. ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

srebhan

Thanks for your contribution @tguenneguez! I do have some comments in the code. IMO, the most important issues are

You are changing unrelated parts of the code resulting in a larger diff than necessary. Please avoid changing code you don't need to touch in this PR. If you want it changed, do it in a separate PR!
Spelling and comments are French AFAICS. Please check spelling and convert everything to English please!

Looking forward to your update of the PR!

srebhan · 2026-07-15T10:13:57Z

+	return cvs
+}
+
+func (e *endpoint) loadCustomProperties(entity interface{}, propertieInclude []string) map[string]interface{} {


propertieInclude is a typo. Did you mean propertiesInclude? The same thing occurs in multiple places throughout the PR...

Exact, that's because of in config, you use :
CustomAttributeInclude
But it's a list of attibutes.

In this way I think it will be great to be "propertieInclude" every where ?

srebhan · 2026-07-15T10:26:07Z

+// resourceInfo is a utility class grouping a type and relevant parameters.
+type resourceInfo struct {
+	resType     string
+	custoFields []string


This abbreviation saves one character while humpering readability a lot. Please be generous and add the m here. :-)

It's because of resourceFilter containe a resType

srebhan · 2026-07-15T10:30:55Z

 			fields = append(fields, af...)
 		}
+		fields = append(fields, resourceInfo.custoFields...)
+		uniqueFields := removeDuplicates(fields)


fields are defined by resourceInfo.custoFields which in turn stem from user-settings, don't they? If so, wouldn't it be better to deduplicate those user-settings in Init instead of doing it in every gather cycle?

It will be, but they are agregate to addFields[resourceInfo.resType].
To be able to do this, it will be necessaire to agregate this info only one time...

srebhan · 2026-07-15T10:31:17Z

Please revert this change!

No change display ? Can you explain me ...

srebhan · 2026-07-15T10:31:44Z

+	VMMetricExclude              []string        `toml:"vm_metric_exclude"`
+	VMInclude                    []string        `toml:"vm_include"`
+	VMExclude                    []string        `toml:"vm_exclude"`
+	VMPropertieInclude           []string        `toml:"vm_propertie_include"`


Typo! Please fix spelling! Same for all other options you introduced.

You speak about :
VMMetricExclude vs VmMetricExclude ?

srebhan · 2026-07-15T10:33:22Z

-	err = f.find(t.Context(), "Datacenter", "/DC0", &dc)
+	ri := resourceInfo{
+		resType:     "Datacenter",
+		custoFields: nil,


Don't explicitly set fields to values they have anyway by Golang's defaults. Same for all other instances.

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

…uenneguez/telegraf into add-custom-properties-vsphere

feat(input.vsphere) : add custom properties

7195b10

tguenneguez changed the title ~~feat(input.vsphere) : add custom properties~~ feat(inputs.vsphere) : add custom properties Jun 25, 2026

tguenneguez changed the title ~~feat(inputs.vsphere) : add custom properties~~ feat(inputs.vsphere): add custom properties Jun 29, 2026

telegraf-tiger Bot added area/vsphere feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 29, 2026

tguenneguez added 6 commits June 29, 2026 15:36

feat(inputs.vsphere) : add custom properties

f86e85f

feat(inputs.vsphere): add custom properties

cd2c9f0

Correction gocritic

8229c22

Corrige syntaxe

f6d7d90

Corrige syntax

7c879d6

Modify the syntax

174e995

srebhan self-assigned this Jul 3, 2026

Correction syntaxe

2480e21

srebhan reviewed Jul 15, 2026

View reviewed changes

srebhan changed the title ~~feat(inputs.vsphere): add custom properties~~ feat(inputs.vsphere): Allow adding custom properties as fields Jul 15, 2026

tguenneguez and others added 11 commits July 15, 2026 13:57

Retour arrière sur une modification inutile

1407119

Symplify code

899b387

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>

Correction retour getExtraData

588b73b

Merge branch 'add-custom-properties-vsphere' of https://github.com/tg…

9c94760

…uenneguez/telegraf into add-custom-properties-vsphere

Corrige les tests

e617e16

Replace resType in resMType

235438b

Translate comments

5beb4b6

Corrige syntaxe

22ae6ac

Modify syntaxe

9ad4016

Correction syntaxe

e06c9c8

Correction syntaxe

48a8df7

Uh oh!

Conversation

tguenneguez commented Jun 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Related issues

Uh oh!

srebhan commented Jul 3, 2026

Uh oh!

tguenneguez commented Jul 3, 2026

Uh oh!

telegraf-tiger Bot commented Jul 3, 2026

Artifact URLs

Uh oh!

srebhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tguenneguez commented Jun 25, 2026 •

edited

Loading