Skip to content

feat(migrations): Add migration for inputs.tail from_beginning option - #19117

Merged
srebhan merged 1 commit into
influxdata:masterfrom
skartikey:feat/migrate-tail-from-beginning
Jun 18, 2026
Merged

feat(migrations): Add migration for inputs.tail from_beginning option#19117
srebhan merged 1 commit into
influxdata:masterfrom
skartikey:feat/migrate-tail-from-beginning

Conversation

@skartikey

@skartikey skartikey commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

The from_beginning option in inputs.tail was deprecated in v1.34.0 for removal in v1.40.0, replaced by initial_read_offset. This adds a migration that maps from_beginning = true to initial_read_offset = "beginning" and false to "saved-or-end" on telegraf config migrate. When initial_read_offset is already set it takes precedence and is kept, dropping from_beginning; if the two disagree the migration warns. The option removal ships separately (#19132) so users can migrate while still on v1.39.x.

Checklist

  • No AI generated code was used in this PR

Related issues

related to #19088

@telegraf-tiger telegraf-tiger Bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 16, 2026
@skartikey skartikey added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 16, 2026

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skartikey! Can we please split the PR into adding the migration and another PR for removing the option. This way we can merge the migration part now and remove the option shortly before v1.40.0 i.e. after the last bug-fix release for v1.39.x... Same for the other PRs...

Comment thread migrations/inputs_tail/migration.go Outdated
The 'from_beginning' option in inputs.tail was deprecated in v1.34.0 for removal in v1.40.0, replaced by 'initial_read_offset'.
@skartikey
skartikey force-pushed the feat/migrate-tail-from-beginning branch from 683396c to 6eacc93 Compare June 18, 2026 14:07
@skartikey skartikey added this to the v1.39.1 milestone Jun 18, 2026
@telegraf-tiger

Copy link
Copy Markdown
Contributor

@srebhan srebhan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@srebhan
srebhan merged commit e4cde29 into influxdata:master Jun 18, 2026
28 of 29 checks passed
skartikey added a commit that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants