Skip to content

Sort interfaces by priority when searching an IP address #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
camilojd wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Sort interfaces by priority when searching an IP address #82

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
11bf99e
Sort interfaces by priority when searching an IP address
Aug 26, 2017
a91deb0
Style fixes
Sep 19, 2017
a24f360
Avoid using possibly undefined `String.startsWith()`
Sep 19, 2017
70d587d
Please the linter
Sep 19, 2017
3a090d0
Use `slice` instead of `substring`
Oct 14, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion lib/ip.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,7 +376,25 @@ ip.address = function(name, family) {
return res[0].address;
}

var all = Object.keys(interfaces).map(function (nic) {
function priority (name) {

@brentvatne brentvatne Sep 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove space before (name for consistency with the rest of the codebase

if (name.startsWith('en') || name.startsWith('eth')) {
return 0;
}
if (name.startsWith('wlan')) {
return 1;
}

return 2;
}

var sortedInterfaces = Object.keys(interfaces).sort(function(a, b) {
a = priority(a);
b = priority(b);

return a - b;

@brentvatne brentvatne Sep 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just return priority(a) - priority(b)?

@camilojd camilojd Sep 19, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brentvatne you're right :-) I did that to debug my code.

});

var all = sortedInterfaces.map(function (nic) {

@brentvatne brentvatne Sep 12, 2017

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should remove space between function and (nic)

//
// Note: name will only be `public` or `private`
// when this is called.
Expand Down