Skip to content

Filter studios and associations by city, open /places on a country - #259

Open
engleek wants to merge 1 commit into
mainfrom
feat/city-and-country-filters
Open

engleek wants to merge 1 commit into
mainfrom
feat/city-and-country-filters

Conversation

@engleek

@engleek engleek commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Part of #258: what a country page links into.

  • /studios?city=… and /associations?city=… (case-insensitive), alongside the existing ?country=. A removable "In Rennes" chip shows the filter. The city is kept as a hidden field, so it survives the other filters ("Has published games" and so on), and changing the country drops it.
  • /places?country=XX opens on the area most of the country's organisations are in. It takes the 5th–95th percentile of their coordinates, so France's overseas places don't zoom the map out to the whole world, and fits that to the map's real size (mapFocus, unit-tested). The list beside the map follows on its own, because it lists what's in view.

Found along the way, not fixed here: /studios and /associations show only their first 50 results, with no pagination, so /studios?country=FR shows 50 of France's 635 studios. The city filter makes this less painful, but it needs its own fix.

Tests

  • Unit: the outlier trimming, places without coordinates, zoom for a country, a continent and a single place.
  • e2e:
    • /studios?country=NO&city=fjordheim… shows only that city's studio;
    • the city survives ticking "Has published games";
    • "Show every city" removes it;
    • /places?country=IS lists an Icelandic studio and not an Australian one.
  • build ✅, vitest 142/142 ✅, Playwright 75/75 ✅

🤖 Generated with Claude Code

For #258, so a country page can link into the lists and the map:

- /studios and /associations take ?city= (case-insensitive), shown as a
  removable "In Rennes" filter. The city stays across the other filters
  (a hidden field) and is dropped when the country changes.
- /places?country=XX opens on the area most of the country's
  organisations are in: their 5th-95th percentile box, so overseas
  places don't zoom the map out to the world, fitted to the map's size
  (mapFocus). The list beside the map follows, as it lists what's in
  view.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant