Repository navigation
Replace the v1 route convention with an explicit route config - #250
Merged
Merged
Conversation
engleek
force-pushed
the
chore/explicit-route-config
branch
from
October 4, 2026 12:41
7307a3d to
165bc39
Compare
Contributor
Author
|
Rebuilt on main after #249 merged, as one commit (force-pushed).
|
app/routes.ts lists every route with route() / index() from @react-router/dev/routes instead of remixRoutesOptionAdapter( createRoutesFromFolders), following the v1 folder convention: dots are path segments, only a sibling folder nests (event.$id/, game.$id/, *.changes/), $.jsx is the splat, admin/ and auth/ are path prefixes. `react-router routes --json` gives the same 63 routes, ids and nesting as before. Removes @remix-run/v1-route-convention, which pulled in @remix-run/dev@1.19.3 and with it the last critical audit finding (tar), and @react-router/remix-routes-option-adapter. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
engleek
force-pushed
the
chore/explicit-route-config
branch
from
October 4, 2026 12:43
165bc39 to
5cb8007
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
app/routes.tsnow lists every route explicitly withroute()/index()from@react-router/dev/routes, instead of usingremixRoutesOptionAdapter(createRoutesFromFolders).@remix-run/v1-route-conventionand@react-router/remix-routes-option-adapterare removed frompackage.json.The config follows the v1 folder convention:
event.$id.edit.jsx→event/:id/edit, at the top level)event.$id/*andgame.$id/*are children ofevent/:idandgame/:id;*.changes/holdsindex+:revisionIdchildren$.jsxis the*splat, andadmin/andauth/are plain path prefixes@react-router/fs-routeswas not used because its flat-routes convention would nestevent.$id.changesandevent.$id.editunderevent.$id, which would change the nesting.Why
@remix-run/v1-route-conventionpulled in@remix-run/dev@1.19.3. Removing it drops 576 packages from the lockfile (no packages added, no versions changed).npm auditVerification
npx react-router routes --jsonbefore and after, normalized for child order: identical (66 entries). Route ids came out identical too, souseRouteLoaderData/matcheslookups are unaffected.npx react-router build: passesnpx vitest run: 24 files, 75 tests passnpx playwright test: 24 passed, 29 failed.maingives exactly the same result with the same 29 tests failing. The failures come from the local database being behind on Prisma migrations (e.g.column `game.tag_list` does not exist), not from this change.🤖 Generated with Claude Code