Repository navigation
Conversation
#161, the organization part (profiles follow once #157 adds Bluesky sign-in): an optional bsky_handle on entity, edited in the org form and linked from the org page with the Bluesky icon. What people type is normalised ("@Studio.bsky.social" or a bsky.app profile URL becomes "studio.bsky.social") and checked with Bluesky's public resolveHandle when saving; a malformed or unknown handle is refused with a message instead of being stored. The API base URL is configurable (BLUESKY_API), so the e2e tests use a local stand-in. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #249, which merged this change into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #161: the organization half. Profiles follow once #157 adds Bluesky sign-in, and they'll reuse the person's handle from there, so the issue stays open.
Change
entity.bsky_handle(migration20261004120000_org_bluesky_handle).@Studio.bsky.socialandhttps://bsky.app/profile/studio.bsky.socialboth becomestudio.bsky.social.com.atproto.identity.resolveHandle(no sign-in needed). A malformed or unknown handle is refused with "No Bluesky account is called …" (or "… isn't a Bluesky handle"), shown as the usual error toast. On edit, the check runs before the update, so the toast says why.bsky.app/profile/<handle>) with the Bluesky icon, next to the website. I checked it in the browser.BLUESKY_API(defaulthttps://public.api.bsky.app), so tests don't depend on Bluesky.Tests
@, case, profile URLs, empty input). The check covers empty → null, a resolving handle, and malformed or unknown → a readable error. Its assumptions match the real API, which returns 200 with a DID, or 400 "Unable to resolve handle".@Sky-Studio.bsky.socialis saved assky-studio.bsky.socialand linked from the org page.Conflicts to expect:
playwright.config.js(#245 also adds a test env var) andprisma/schema.prisma(#241). They're small; I'll rebuild whichever goes second.🤖 Generated with Claude Code