Repository navigation
Conversation
The event page reads each attendee's avatar.thumbnail_url, but the loader passed the raw image row, which has no such field, so every attendee fell back to their initial (the stray "y" on live event pages). computeEvent now turns participants' avatars into image links. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
engleek
force-pushed
the
fix/attendee-avatars
branch
from
October 3, 2026 16:20
1c08064 to
3ac1086
Compare
Contributor
Author
|
Superseded by #249, which merged this change into main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attendee avatars on event pages never showed a photo. The page reads
avatar.thumbnail_url, but the loader passed each attendee's rawimagerow, which has no such field, so everyone fell back to their initial. That's the stray "y" from the site review, finding #4, which turned out to be an avatar and not a broken count.Found while auditing images for #194 / #225.
Change
computeEventmaps each participant's avatar throughgetImageLinks, as every other image is. Events loaded without participants'personrows pass through unchanged.Tests
A new e2e test gives the seeded member an avatar image and joins them to an event (through Prisma, restored afterwards). The attendee's avatar
imgmust have the image's URL.main: it fails (src="").🤖 Generated with Claude Code