Skip to content

Render game tags as lists - #223

Closed
engleek wants to merge 1 commit into
mainfrom
fix/tag-lists
Closed

engleek wants to merge 1 commit into
mainfrom
fix/tag-lists

Conversation

@engleek

@engleek engleek commented Oct 3, 2026

Copy link
Copy Markdown
Contributor

Fixes #201.

Game cards and the game page rendered tags as bare chips inside a <div>, spaced only by CSS margins. Screen readers, copy-paste and text tools got one run-on word, e.g. "soloplatformroguelikeaction".

Change

  • TagList (app/components/TagList.jsx) renders tags as a list labelled "Tags", one li per chip, spaced with gap.
  • Game page: with linked, each tag still links to /games?tags=<name>, now URL-encoded.
  • Cards and the game page use it. I checked both in the browser; they look as before.

Not changed: the tag filter on /games. Those chips are clickable but aren't buttons, so they can't be reached with the keyboard. That's a separate accessibility fix, worth its own issue.

Tests

A new e2e test opens /games and checks:

  • the first card has a list named "Tags" with several items;
  • its rendered text separates the names;
  • the game page also has a tag list.

On main: it fails. Locally: the full e2e suite (38) and the unit and story tests (51) pass.

🤖 Generated with Claude Code

Game cards and the game page showed tags as bare chips in a <div>,
spaced only by margins, so screen readers, copy-paste and text tools got
one run-on word ("soloplatformroguelikeaction").

A TagList component renders them as a list labelled "Tags", one item per
tag, spaced with gap; on the game page each tag still links to the
filtered games list (its name is now URL-encoded). They look the same.

Fixes #201.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@engleek

engleek commented Oct 4, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #249, which merged this change into main.

@engleek engleek closed this Oct 4, 2026
@engleek
engleek deleted the fix/tag-lists branch October 9, 2026 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tag chips have no separators in text and screen-reader output

1 participant