Repository navigation
Conversation
engleek
force-pushed
the
fix/org-type-labels
branch
from
October 3, 2026 16:13
8323ec0 to
4af6fc5
Compare
Cards showed the raw "studio" and an ad-hoc "assoc", and the org page the bare enum value: Chakra v2's Badge upper-cased these, v3's doesn't. The type colours were defined four times over. One orgTypes module now holds each type's label, short label and colour palette. Cards show "Studio" / "Assoc." on their small thumbnail badge, the org page "Studio" / "Association", and the form and map markers take their labels and colours from the same place. Fixes #202. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
engleek
force-pushed
the
fix/org-type-labels
branch
from
October 4, 2026 08:22
4af6fc5 to
e99849e
Compare
This was referenced Oct 4, 2026
engleek
added a commit
that referenced
this pull request
Oct 4, 2026
The seed drew latitudes from the whole -90°..90° range, but Web Mercator maps stop near ±85°: past that the tile row is negative and pigeon-maps loads no tiles. About one place in twenty landed there, so the map-tile e2e test failed whenever the first event happened to be one (#222's run 37188728932). Real places never are; keep seeded latitudes within ±80°. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #249, which merged this change into main. |
engleek
added a commit
that referenced
this pull request
Oct 4, 2026
The seed drew latitudes from the whole -90°..90° range, but Web Mercator maps stop near ±85°: past that the tile row is negative and pigeon-maps loads no tiles. About one place in twenty landed there, so the map-tile e2e test failed whenever the first event happened to be one (#222's run 37188728932). Real places never are; keep seeded latitudes within ±80°. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #202.
studioandassoc, in lowercase.association. Chakra v2's Badge uppercased these labels and v3's doesn't, so they surfaced as raw values with the migration./placesmarkers.Change
app/utils/orgTypes.jsholds each type'slabel,shortLabeland colour palette, withorgTypeLabel(type, { short })andorgTypeColor(type). Unknown types fall back to the raw value and gray./placesmarkers take their labels and colours from the module.Tests
A new e2e test checks
/studiosand/associations: the cards show "Studio" / "Assoc.", and the first org's page shows "Studio" / "Association".main: it fails.🤖 Generated with Claude Code