fix(mobile): only toggle backup from the switch, not the whole row#29236
Merged
Conversation
tapping anywhere on the enable backup row flipped backup on or off, so it was easy to toggle by accident. now only the switch does it.
|
📱 Android release APK (universal) — Download: https://github.com/immich-app/immich/actions/runs/27880076466/artifacts/7767850778 QR codeInstalls as a separate app (applicationId |
shenlong-tanwen
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tapping anywhere on the "enable backup" row toggled backup on/off, not just the switch. easy to flip by accident — the reporter hit it reaching for "view details", and it's worse when the row shifts as the upload counters appear.
dropped the row-wide tap so only the switch toggles it now.
fixes #23051
tested on a pixel: tapping the row text used to flip the switch, now it doesn't, and the switch itself still works both ways.