Skip to content

OF-3336: Bind JDWP debugger to localhost#3440

Open
guusdk wants to merge 1 commit into
igniterealtime:mainfrom
guusdk:OF-3336_java-debug-interface
Open

OF-3336: Bind JDWP debugger to localhost#3440
guusdk wants to merge 1 commit into
igniterealtime:mainfrom
guusdk:OF-3336_java-debug-interface

Conversation

@guusdk

@guusdk guusdk commented Jul 10, 2026

Copy link
Copy Markdown
Member

Configure the JDWP agent to listen on localhost:5005 instead of using a bare port number.

While JDWP cannot bind to all loopback interfaces without also accepting remote connections, using localhost makes the intent to bind locally explicit and is likely to provide more consistent behavior than relying on the JVM's default address selection (which for me, picked the IPv6 loopback while my IDE tried the IPv4 one, leading to confusion).

Configure the JDWP agent to listen on `localhost:5005` instead of using a bare port number.

While JDWP cannot bind to all loopback interfaces without also accepting remote connections, using `localhost` makes the intent to bind locally explicit and is likely to provide more consistent behavior than relying on the JVM's default address selection (which for me, picked the IPv6 loopback while my IDE tried the IPv4 one, leading to confusion).
@guusdk guusdk added the backport 5.1 on merge, GHA will generate a PR with these changes against 5.1 branch label Jul 10, 2026
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c72f87a8-8da6-46d7-b3e0-3c747330df9b

📥 Commits

Reviewing files that changed from the base of the PR and between 7c41585 and 07015c4.

📒 Files selected for processing (1)
  • distribution/src/bin/openfire.sh

📝 Walkthrough

Walkthrough

The -debug option in openfire.sh now configures JDWP to listen on localhost:5005 instead of using the previous wildcard binding. Other option handling and command construction remain unchanged.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description matches the change to bind JDWP to localhost:5005 and explains the local-binding intent.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport 5.1 on merge, GHA will generate a PR with these changes against 5.1 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant