Skip to content

[Enhancement] Remove unnecessary variable - #14

Open
maroqijalil wants to merge 2 commits into
masterfrom
enhancement/prepare-soccer
Open

[Enhancement] Remove unnecessary variable#14
maroqijalil wants to merge 2 commits into
masterfrom
enhancement/prepare-soccer

Conversation

@maroqijalil

@maroqijalil maroqijalil commented Jun 6, 2023

Copy link
Copy Markdown
Member

Jira Link:

Description

Remove the unnecessary is_calibrated variable from the Robot model and standardize node definitions by calling static helper from the related node.

Type of Change

  • Bugfix
  • Enhancement
  • New feature
  • Breaking change (fix or feature that would cause the existing functionality not to work as expected)

How Has This Been Tested?

  • New unit tests added.
  • Manual tested.

Checklist:

  • Using Branch Name Convention
    • feature/JIRA-ID-SHORT-DESCRIPTION if it has a JIRA ticket
    • enhancement/SHORT-DESCRIPTION if has/has no JIRA ticket and contains enhancement
    • hotfix/SHORT-DESCRIPTION if the change doesn't need to be tested (urgent)
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have made the documentation for the corresponding changes.

@maroqijalil maroqijalil self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant