min and max methods for Length#3367
Open
hecrj wants to merge 23 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
minandmaxmethods to theLengthtype, allowing users to define minimum and maximum constraints for any widget:The implementation involved introducing additional min/max passes to our
flexlayout logic, as well as changing the sizing inheritance of widgets to account for constraint propagation over each axis. However, while elements may be visited multiple times,layoutis only ever called once for each of them; keeping the single-pass layout philosophy of the library intact.The changes here also introduce a bunch of new layout integration tests, which should freeze the requirements of the
flexlogic and the layout system to avoid future regressions.I suspect there may be plenty of edge cases that the current logic does not handle well; so we will likely have to iterate a bunch.