Invalidate buffer cache when fonts are loaded#3352
Open
airstrike wants to merge 1 commit into
Open
Conversation
The text BufferCache keys on (content, font, size, ...) but does not account for fonts loaded after a buffer is first shaped, because it assumes all fonts are loaded at startup. As a result, a buffer using a given missing font but shaped with a fallback font would persist in the cache even after said font was loaded, because the key hash hadn't changed. Fix: pass the FontSystem version into `Cache::allocate` so when the version advances after a font is loaded, the cache is invalidated and buffers are reshaped correctly with the right font.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The text BufferCache keys on (content, font, size, ...) but does not account for fonts loaded after a buffer is first shaped, because it assumes all fonts are loaded at startup.
As a result, a buffer using a given missing font but shaped with a fallback font would persist in the cache even after said font was loaded, because the key hash hadn't changed.
Fix: pass the FontSystem version into
Cache::allocateso when the version advances after a font is loaded, the cache is invalidated and buffers are reshaped correctly with the right font.