Skip to content

Feat/1178#357

Merged
razasaddiqi merged 13 commits into
mainfrom
feat/1178
Jul 22, 2026
Merged

Feat/1178#357
razasaddiqi merged 13 commits into
mainfrom
feat/1178

Conversation

@razasaddiqi

@razasaddiqi razasaddiqi commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Checklist

  • Tests were added/updated according to the feature/bugfix/change made
  • Version was rolled according to semver requirements
  • API endpoints openapi schema was updated if applicable

Changes

  • Adds new agent settings tabs for evals
  • Unit and playwright journey 63 for evals
  • Use translation instead of static labels and also adds translations for tabs name
Screenshot 2026-07-22 at 3 02 39 AM Screenshot 2026-07-22 at 3 02 29 AM Screenshot 2026-07-22 at 3 02 21 AM Screenshot 2026-07-22 at 3 02 12 AM Screenshot 2026-07-22 at 3 01 51 AM Screenshot 2026-07-22 at 3 01 45 AM Screenshot 2026-07-22 at 3 01 38 AM Screenshot 2026-07-22 at 3 01 30 AM Screenshot 2026-07-22 at 3 01 23 AM Screenshot 2026-07-22 at 3 01 16 AM Screenshot 2026-07-22 at 3 04 07 AM

@razasaddiqi
razasaddiqi requested a review from mamigot as a code owner July 21, 2026 19:37
@mamigot

mamigot commented Jul 21, 2026

Copy link
Copy Markdown
Member

Claude finished @razasaddiqi's task —— View job


E2E Coverage Bot

  • Dismiss stale REQUEST_CHANGES reviews (none found)
  • Identify changed files — no new page.tsx routes added
  • Run mechanical coverage check — PASSED (562 → 579 checkpoints, +17)
  • Read coverage files — developer already updated e2e/coverage.json and e2e/COVERAGE.md
  • Applied decision logic — CASE C: spec + coverage files present and correct → Approved

Journey 63 — Mentor Evaluation Tab correctly registered with 17 checkpoints, all "status": "covered".

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — All Good

New routes are covered and coverage files are up to date.

Coverage check result: 562 → 579 checkpoints (+17) — no regression.

Journey 63 — Mentor Evaluation Tab is correctly registered in e2e/coverage.json with:

  • Spec: 63-mentor-evaluation-tab.spec.ts
  • Source files: evaluation-tab/index.tsx, use-mentor-segments.ts
  • 17 checkpoints, all "status": "covered"

e2e/COVERAGE.md is also updated to match. No action needed.

@mamigot

mamigot commented Jul 21, 2026

Copy link
Copy Markdown
Member

Claude finished @razasaddiqi's task —— View job


E2E Coverage Bot

  • Dismiss stale REQUEST_CHANGES reviews (none found)
  • Identify changed files — no new page.tsx routes added
  • Run mechanical coverage check — PASSED (562 → 579 checkpoints, +17)
  • Read coverage files — developer already updated e2e/coverage.json and e2e/COVERAGE.md
  • Applied decision logic — CASE C: spec + coverage files present and correct → Approved

Journey 63 — Mentor Evaluation Tab correctly registered with 17 checkpoints, all "status": "covered".

View job

@mamigot mamigot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ E2E Coverage — All Good

New routes are covered and coverage files are up to date.

Coverage check result: 562 → 579 checkpoints (+17) — no regression.

Journey 63 — Mentor Evaluation Tab is correctly registered in e2e/coverage.json with:

  • Spec: 63-mentor-evaluation-tab.spec.ts
  • Source files: evaluation-tab/index.tsx, use-mentor-segments.ts
  • 17 checkpoints, all "status": "covered"

e2e/COVERAGE.md is also updated to match. No action needed.

@razasaddiqi razasaddiqi added the run-tests Trigger PR validation pipeline label Jul 21, 2026
@razasaddiqi
razasaddiqi merged commit c386b7e into main Jul 22, 2026
31 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-tests Trigger PR validation pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants