Fix/2155#323
Open
conradmugabe wants to merge 2 commits into
Open
Conversation
A visitor arriving via a shareable link (`?token=...`) should be able to chat regardless of RBAC. The backend validates the token on session creation and only returns a sessionId when it accepts it, so a token paired with an active session bypasses the RBAC chat gate. A token alone is not enough (invalid token, or the brief window before create-session resolves), so the input stays gated until the session exists. The RBAC "no permission" placeholder is suppressed whenever a token is present, since RBAC does not apply to share-link visitors. Also extract `isSendDisabled` (RBAC gate + active session) to replace the duplicated `isChatDisabledByRbac || !sessionId` check across the submit guard and send/tool buttons, and add unit coverage for the bypass. This also repairs the chat-input-form test suite, which was failing on main for lack of next/navigation and useChatPrivacy mocks. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Member
|
Claude finished @conradmugabe's task —— View job E2E Coverage Review
Result: ✅ PR approved. No new app routes were introduced and all existing coverage (545 checkpoints) remains intact. |
mamigot
approved these changes
Jul 10, 2026
mamigot
left a comment
mamigot
left a comment
Member
There was a problem hiding this comment.
✅ E2E Coverage — No Issues
No new app routes were introduced. All existing coverage is intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes