IBX-12033: Fixed content name reverting when translations are published in parallel#779
Open
Sztig wants to merge 2 commits into
Open
IBX-12033: Fixed content name reverting when translations are published in parallel#779Sztig wants to merge 2 commits into
Sztig wants to merge 2 commits into
Conversation
ibexa-workflow-automation-1
Bot
requested review from
Steveb-p,
ViniTou,
alongosz,
barw4,
bnowak,
ciastektk,
konradoboza,
mikadamczyk,
tbialcz and
wiewiurdp
and removed request for
a team
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Prerequisite for the bug to happen - content type must contain non translatable field.
When 2 translations of the same content were edited and published in parallel (order of operations described in detail in the jira ticket), publishing the the second draft reverted the content name to its pre published value.
During the publishing the second translation, we already query the stale content through
internalLoadContentById(), thencopyTranslationsFromPublishedVersion()manages to "fix" the stale content .However, we still pass the same initially queried content with potentially outdated name to
copyNonTranslatableFieldsFromPublishedVersion(). My fix here is just reloading the content again in this method to not rely on the stale content.Case described in jira ticket has been covered in an integration test.