Repository navigation
feat: echidna prove --output json, echidna-core client crate, Zig FFI CI - #409
Merged
Merged
Conversation
- `echidna prove --output json` prints exactly one echidna.prove.result/1 object (JCS-canonical I-JSON) on stdout; logs go to stderr. Statuses map from ProverOutcome (verified/failed/error/timeout/unknown). trust.confidence is null unless receipt-backed (epistemic-types receipt/warrant pattern). Human output stays the default. Golden-byte unit tests for every status, planted non-canonical mutants, and end-to-end binary tests (TypedWasm). - echidna-core 0.2.0: ProverKind moved in (re-exported from echidna, no source change), prove_result contract type with strict parser, and the trust kernel re-exported as echidna_core::trust. README documents the git-dependency recipe and stability policy. - ffi/zig compiles again (opaque Handle, page allocator, no libc) and is gated by a new zig-ffi-ci.yml: zig fmt, zig build test, and the cicd-suite unified-api-adapter purity check. tentacles.zig no longer uses std.io; poll_events gained tests. - chapel-ci: zig build -Dcpu=baseline (fixes SIGILL on main). - rust-ci: check/clippy/test with --workspace (crate tests never ran). - Idris2 ABI: %default total in Gnn and TacticRecord. - CREUSOT-SETUP.adoc: remove false hard-gate/done claims; record why Creusot does not run in CI. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
hyperpolymath
enabled auto-merge (squash)
October 5, 2026 18:33
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters (2)
📒 Files selected for processing (31)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Hypatia flagged the @ptrCast/@aligncast used to recover internal state from an opaque handle (CWE-704). An extern struct with C-compatible fields needs no casts; C still treats the pointer as opaque. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #407 (merged as b97a799), so this PR is based on
main, not stacked.What this does
1.
echidna prove --output jsonimplements the sharedechidna.prove.result/1contract.statuscomes fromProverOutcome::prove_status:Proved→verified,NoProofFound→failed,Timeout→timeout,InconsistentPremises→unknown, and input, prover or system failures →error. Failures before the check (no backend, unreadable file, parse error) are alsoerrorobjects.verified.trust.confidenceisnullunless a receipt backs it. This is the epistemic-types receipt/warrant pattern, used as a pattern only, not as a dependency. This path checks no certificate, so the value is alwaysnull.trust.axiomscomes from ECHIDNA's axiom tracker.docs/PROVE-RESULT-CONTRACT.adoc.2.
echidna-core0.2.0 can now be used by clients such as echidnabot and proof-burrower.ProverKindmoved into the crate.echidna::ProverKindandechidna::provers::ProverKindre-export it, so no ECHIDNA source changed.prove_result(the contract type, a JCS serialiser and a strict parser).trust, a re-export of theechidna-core-creusottrust kernel that echidnabot already pins.crates/echidna-core/README.adoc.3. Zig FFI and the unified-api-adapter check.
ffi/zigdid not compile on any Zig release (0.14.1, 0.15.2 and 0.16.0 all failed) and no workflow built it.Handle, page allocator, no libc).zig-ffi-ci.ymlrunszig fmt --check,zig build test(45 tests) and thehyperpolymath/cicd-suitepurity check.std.iouse, intentacles.zig, is gone, andpoll_eventsgained tests.4. CI fixes.
chapel-ci.ymlbuilds Zig with-Dcpu=baseline. The artifact runs on a different runner, and that caused the SIGILL in "Rust Build with Chapel Feature" on main.rust-ci.ymlcheck, clippy and test now pass--workspace. Before, only the root package was tested, so theechidna-coreand trust-kernel tests never ran.5. Idris2 ABI.
%default totaltoEchidnaABI.GnnandEchidnaABI.TacticRecord; the package still type-checks.CapnSchemas.idrandNeSyAssistTesting.idrare not in the ipkg, so CI does not check them. This is recorded in the wiki table.6. Creusot: precisely why it is not in CI.
cargo check -p echidna-core-creusot --features creusotfails with 34 errors, becausecreusot-contractsis not a dependency.CREUSOT-SETUP.adocno longer claims the job is a hard gate or that milestones 8c-M1..M3 are done. The annotations remain stated, not proved.Verification (local, rustc 1.99.0)
cargo fmt --all -- --checkpasses.cargo clippy --locked --workspace --all-targets -- -D warningspasses.cargo test --locked --workspace --all-targetspasses.zig build testpasses: 45/45 on Zig 0.15.2.idris2 --build src/abi/echidnaabi.ipkgpasses on Idris2 0.7.0.gh actions-lock --no-fixis clean over 35 workflows.Not in this PR
src/rust/ids.rs, and this PR mints no IDs.Deferred red checks (§5c)
Rust Build — Real Chapel Library (allow-fail, L2.3+ gate): was already red on main before this PR. Deferred to ci: 'Rust Build — Real Chapel Library' fails to link (undefined chapel_* symbols) #408, which has acceptance criteria.🤖 Generated with Claude Code